[ckan-changes] [ckan/ckan] 17a3db: Modernize package model tests

Fri May 10 12:32:48 UTC 2019

  Branch: refs/heads/modernize-model-tests
  Home:   https://github.com/ckan/ckan
  Commit: 17a3db6bf20bddff57800bd3c4e5b2ad153ae641
      https://github.com/ckan/ckan/commit/17a3db6bf20bddff57800bd3c4e5b2ad153ae641
  Author: David Read <david.read at hackneyworkshop.com>
  Date:   2019-05-10 (Fri, 10 May 2019)

  Changed paths:
    M ckan/model/tag.py
    R ckan/tests/legacy/models/test_extras.py
    M ckan/tests/legacy/models/test_package.py
    A ckan/tests/model/test_package.py
    A ckan/tests/model/test_package_extra.py
    A ckan/tests/model/test_tags.py

  Log Message:
  -----------
  Modernize package model tests

* The rest of ckan/tests/legacy/models/test_package.py will go with the
revisioning.
* tag.by_name() is deprecated because it doesnt seem used anywhere and
is broken - missing a join in the query, so the Tag.name filter does
nothing.
* tag.search_by_name() is deprecated because it isn't used in core ckan.
I think some sites will have a tag search, but they should really have
the code in their own repo, so we're giving them warning.