[ckan-changes] [ckan/ckan] 6c474b: Improvement according to C403/C404 flake8 comprehe...

David Read noreply at github.com
Fri Nov 8 22:51:14 UTC 2019

  Branch: refs/heads/flake8-comprehensions
  Home:   https://github.com/ckan/ckan
  Commit: 6c474b403834c9b96833835a493f14dac0e65cc5
  Author: David Read <david.read at hackneyworkshop.com>
  Date:   2019-11-08 (Fri, 08 Nov 2019)

  Changed paths:
    M ckan/config/middleware/flask_app.py
    M ckan/lib/changes.py
    M ckan/lib/cli.py
    M ckan/lib/config_tool.py
    M ckan/lib/navl/dictization_functions.py
    M ckan/lib/search/__init__.py
    M ckan/tests/legacy/lib/test_resource_search.py
    M ckan/tests/legacy/logic/test_action.py
    M ckan/tests/legacy/models/test_group.py
    M ckan/tests/legacy/test_plugins.py
    M ckan/tests/logic/action/test_get.py
    M ckanext/datastore/backend/postgres.py
    M ckanext/reclineview/plugin.py

  Log Message:
  Improvement according to C403/C404 flake8 comprehension rule

C403 Unnecessary list comprehension - rewrite as a set comprehension.
C404 Unnecessary list comprehension - rewrite as a dict comprehension.

However I left 7 C403 violations where I think it is clearer to leave as
it is - tests that compare a set() to a set().

More information about the ckan-changes mailing list