[ckan-changes] [ckan/ckan] 487c13: Improvement according to C407 flake8 comprehension...

Sun Nov 10 14:21:48 UTC 2019

  Branch: refs/heads/master
  Home:   https://github.com/ckan/ckan
  Commit: 487c13e8525e593894f91bfa774378618d38c510
      https://github.com/ckan/ckan/commit/487c13e8525e593894f91bfa774378618d38c510
  Author: David Read <david.read at hackneyworkshop.com>
  Date:   2019-11-08 (Fri, 08 Nov 2019)

  Changed paths:
    M ckan/lib/dictization/model_dictize.py
    M ckan/tests/legacy/functional/api/model/test_group.py
    M ckan/tests/legacy/functional/api/model/test_vocabulary.py
    M ckan/tests/legacy/lib/test_solr_search_index.py
    M ckan/tests/lib/search/test_index.py
    M ckan/tests/lib/test_datapreview.py
    M ckan/tests/logic/action/test_create.py
    M ckan/tests/logic/action/test_delete.py
    M ckan/tests/logic/action/test_get.py
    M ckan/tests/logic/action/test_update.py
    M ckan/tests/logic/test_conversion.py

  Log Message:
  -----------
  Improvement according to C407 flake8 comprehension rule

C407 Unnecessary list comprehension - 'sorted' can take a generator

  Commit: 9a13a4b71a458d943d9110b0a814e79ff7f90792
      https://github.com/ckan/ckan/commit/9a13a4b71a458d943d9110b0a814e79ff7f90792
  Author: David Read <david.read at hackneyworkshop.com>
  Date:   2019-11-08 (Fri, 08 Nov 2019)

  Changed paths:
    M ckan/tests/legacy/lib/test_resource_search.py

  Log Message:
  -----------
  Improvement according to C406 flake8 comprehension rule

C406 Unnecessary (list/tuple) literal - rewrite as a dict literal.

  Commit: 44cf609e7e0455fd234e9199f1d38a129ec1ee05
      https://github.com/ckan/ckan/commit/44cf609e7e0455fd234e9199f1d38a129ec1ee05
  Author: David Read <david.read at hackneyworkshop.com>
  Date:   2019-11-08 (Fri, 08 Nov 2019)

  Changed paths:
    M ckan/tests/helpers.py

  Log Message:
  -----------
  Improvement according to C409 flake8 comprehension rule

C409 Unnecessary (list/tuple) passed to tuple() - (remove the outer call to tuple()/rewrite as a tuple literal).

  Commit: 6c474b403834c9b96833835a493f14dac0e65cc5
      https://github.com/ckan/ckan/commit/6c474b403834c9b96833835a493f14dac0e65cc5
  Author: David Read <david.read at hackneyworkshop.com>
  Date:   2019-11-08 (Fri, 08 Nov 2019)

  Changed paths:
    M ckan/config/middleware/flask_app.py
    M ckan/lib/changes.py
    M ckan/lib/cli.py
    M ckan/lib/config_tool.py
    M ckan/lib/navl/dictization_functions.py
    M ckan/lib/search/__init__.py
    M ckan/tests/legacy/lib/test_resource_search.py
    M ckan/tests/legacy/logic/test_action.py
    M ckan/tests/legacy/models/test_group.py
    M ckan/tests/legacy/test_plugins.py
    M ckan/tests/logic/action/test_get.py
    M ckanext/datastore/backend/postgres.py
    M ckanext/reclineview/plugin.py

  Log Message:
  -----------
  Improvement according to C403/C404 flake8 comprehension rule

C403 Unnecessary list comprehension - rewrite as a set comprehension.
C404 Unnecessary list comprehension - rewrite as a dict comprehension.

However I left 7 C403 violations where I think it is clearer to leave as
it is - tests that compare a set() to a set().

  Commit: c67c23c087db5372f8185e4cc953e32d7dda5ef0
      https://github.com/ckan/ckan/commit/c67c23c087db5372f8185e4cc953e32d7dda5ef0
  Author: Adrià Mercader <amercadero at gmail.com>
  Date:   2019-11-10 (Sun, 10 Nov 2019)

  Changed paths:
    M ckan/config/middleware/flask_app.py
    M ckan/lib/changes.py
    M ckan/lib/cli.py
    M ckan/lib/config_tool.py
    M ckan/lib/dictization/model_dictize.py
    M ckan/lib/navl/dictization_functions.py
    M ckan/lib/search/__init__.py
    M ckan/tests/helpers.py
    M ckan/tests/legacy/functional/api/model/test_group.py
    M ckan/tests/legacy/functional/api/model/test_vocabulary.py
    M ckan/tests/legacy/lib/test_resource_search.py
    M ckan/tests/legacy/lib/test_solr_search_index.py
    M ckan/tests/legacy/logic/test_action.py
    M ckan/tests/legacy/models/test_group.py
    M ckan/tests/legacy/test_plugins.py
    M ckan/tests/lib/search/test_index.py
    M ckan/tests/lib/test_datapreview.py
    M ckan/tests/logic/action/test_create.py
    M ckan/tests/logic/action/test_delete.py
    M ckan/tests/logic/action/test_get.py
    M ckan/tests/logic/action/test_update.py
    M ckan/tests/logic/test_conversion.py
    M ckanext/datastore/backend/postgres.py
    M ckanext/reclineview/plugin.py

  Log Message:
  -----------
  Merge pull request #5066 from ckan/flake8-comprehensions

Flake8 comprehensions

Compare: https://github.com/ckan/ckan/compare/d59c0b6bc223...c67c23c087db