[ckan-changes] [ckan/ckan] c50374: Unit tests for changes.py in #4929

Thu Sep 5 08:50:40 UTC 2019

  Branch: refs/heads/4929-SFB-ELAINE-version-control
  Home:   https://github.com/ckan/ckan
  Commit: c50374e52cefde0f792565141582c0901abb86ae
      https://github.com/ckan/ckan/commit/c50374e52cefde0f792565141582c0901abb86ae
  Author: David Read <david.read at hackneyworkshop.com>
  Date:   2019-08-12 (Mon, 12 Aug 2019)

  Changed paths:
    M ckan/lib/changes.py
    M ckan/lib/helpers.py
    M ckan/logic/action/patch.py
    M ckan/templates/snippets/changes/resource_format.html
    A ckan/tests/lib/test_changes.py

  Log Message:
  -----------
  Unit tests for changes.py in #4929

5 tests fail because they need additions to changes.py:
* add & remove of owner_org
* add/change/remove of resource_extras

I've included a couple of other little improvements to changes.py too.

  Commit: ac4c9259bfe05cd1ba9ffc4fb269bc70fb1105e8
      https://github.com/ckan/ckan/commit/ac4c9259bfe05cd1ba9ffc4fb269bc70fb1105e8
  Author: David Read <david.read at hackneyworkshop.com>
  Date:   2019-08-12 (Mon, 12 Aug 2019)

  Changed paths:
    M ckan/lib/helpers.py
    M ckan/templates/package/changes.html
    M ckan/tests/lib/test_helpers.py

  Log Message:
  -----------
  Added escaping to activity_list_select and test

  Commit: 08a900418f52976721bf45e985fb228b4842fc6d
      https://github.com/ckan/ckan/commit/08a900418f52976721bf45e985fb228b4842fc6d
  Author: hayley-leblanc <leblan_h1 at denison.edu>
  Date:   2019-08-12 (Mon, 12 Aug 2019)

  Changed paths:
    M ckan/lib/changes.py
    M ckan/lib/helpers.py
    M ckan/public/base/css/main.css
    M ckan/public/base/less/activity.less
    M ckan/templates/package/changes.html
    R ckan/templates/snippets/changes/custom_fields.html
    A ckan/templates/snippets/changes/extra_fields.html
    M ckan/templates/snippets/changes/resource_name.html

  Log Message:
  -----------
  Renaming, move new CSS to less file

  Commit: 427c2250d8ca1c63864583e58a96fa8342305c4b
      https://github.com/ckan/ckan/commit/427c2250d8ca1c63864583e58a96fa8342305c4b
  Author: hayley-leblanc <leblan_h1 at denison.edu>
  Date:   2019-08-12 (Mon, 12 Aug 2019)

  Changed paths:
    M ckan/lib/changes.py
    M ckan/lib/helpers.py
    M ckan/templates/package/changes.html
    M ckan/templates/package/snippets/change_item.html
    M ckan/views/dataset.py

  Log Message:
  -----------
  Rename original to old, change_range to changes_multiple, fix translation in changes.html

  Commit: 32fb147b300966a3d8b5553eb7499c6b5bad4bdc
      https://github.com/ckan/ckan/commit/32fb147b300966a3d8b5553eb7499c6b5bad4bdc
  Author: hayley-leblanc <leblan_h1 at denison.edu>
  Date:   2019-08-12 (Mon, 12 Aug 2019)

  Changed paths:
    M ckan/lib/changes.py
    M ckan/templates/snippets/changes/extension_fields.html
    M ckan/templates/snippets/changes/extra_fields.html

  Log Message:
  -----------
  Rename field/field_value to key/value

  Commit: 0db0479a260bb9810aa2dc675e40e6dc775cc6db
      https://github.com/ckan/ckan/commit/0db0479a260bb9810aa2dc675e40e6dc775cc6db
  Author: hayley-leblanc <leblan_h1 at denison.edu>
  Date:   2019-08-12 (Mon, 12 Aug 2019)

  Changed paths:
    M ckan/lib/changes.py
    R ckan/templates/snippets/changes/source_url.html
    A ckan/templates/snippets/changes/url.html

  Log Message:
  -----------
  Rename source_url to url

  Commit: 29763fea4e122f3e88c73658fa971442990ad0e5
      https://github.com/ckan/ckan/commit/29763fea4e122f3e88c73658fa971442990ad0e5
  Author: hayley-leblanc <leblan_h1 at denison.edu>
  Date:   2019-08-12 (Mon, 12 Aug 2019)

  Changed paths:
    M ckan/lib/changes.py
    M ckan/templates/package/changes.html
    M ckan/templates/snippets/changes/extra_fields.html
    M ckan/templates/snippets/changes/tags.html
    M ckan/tests/lib/test_changes.py
    M ckan/views/dataset.py

  Log Message:
  -----------
  Clearer template method names, standardize old/new naming, remove new_pkg from tests

  Commit: e03def96b5b659493cee053f20fa9689e234eb01
      https://github.com/ckan/ckan/commit/e03def96b5b659493cee053f20fa9689e234eb01
  Author: hayley-leblanc <leblan_h1 at denison.edu>
  Date:   2019-08-12 (Mon, 12 Aug 2019)

  Changed paths:
    M ckan/lib/changes.py
    M ckan/templates/package/snippets/change_item.html
    M ckan/templates/snippets/changes/author.html
    M ckan/templates/snippets/changes/author_email.html
    M ckan/templates/snippets/changes/delete_resource.html
    R ckan/templates/snippets/changes/description.html
    M ckan/templates/snippets/changes/extension_fields.html
    M ckan/templates/snippets/changes/extra_fields.html
    M ckan/templates/snippets/changes/license.html
    M ckan/templates/snippets/changes/maintainer.html
    M ckan/templates/snippets/changes/maintainer_email.html
    M ckan/templates/snippets/changes/name.html
    M ckan/templates/snippets/changes/new_file.html
    M ckan/templates/snippets/changes/new_resource.html
    A ckan/templates/snippets/changes/notes.html
    M ckan/templates/snippets/changes/org.html
    M ckan/templates/snippets/changes/private.html
    M ckan/templates/snippets/changes/resource_desc.html
    M ckan/templates/snippets/changes/resource_format.html
    M ckan/templates/snippets/changes/resource_name.html
    M ckan/templates/snippets/changes/tags.html
    M ckan/templates/snippets/changes/title.html
    M ckan/templates/snippets/changes/url.html
    M ckan/templates/snippets/changes/version.html

  Log Message:
  -----------
  Rename description to notes and 'ah' parameter to 'change'

  Commit: 72e49977e7ce46b69200626af9be576f8caa3c78
      https://github.com/ckan/ckan/commit/72e49977e7ce46b69200626af9be576f8caa3c78
  Author: hayley-leblanc <leblan_h1 at denison.edu>
  Date:   2019-08-12 (Mon, 12 Aug 2019)

  Changed paths:
    M ckan/lib/changes.py
    M ckan/templates/snippets/changes/org.html
    M ckan/tests/lib/test_helpers.py

  Log Message:
  -----------
  Handle added/removed orgs and fix syntax in test_helpers.py

  Commit: db4f56ffbb90cbd67ada284834a6b3ad24854985
      https://github.com/ckan/ckan/commit/db4f56ffbb90cbd67ada284834a6b3ad24854985
  Author: hayley-leblanc <leblan_h1 at denison.edu>
  Date:   2019-08-12 (Mon, 12 Aug 2019)

  Changed paths:
    M ckan/lib/changes.py
    A ckan/templates/snippets/changes/resource_extras.html
    M ckan/tests/lib/test_changes.py

  Log Message:
  -----------
  Add check for changes to resource extra fields, fix some test failures

  Commit: e06f5476f457adeb0b0a38007d3336a92cea2b5f
      https://github.com/ckan/ckan/commit/e06f5476f457adeb0b0a38007d3336a92cea2b5f
  Author: hayley-leblanc <leblan_h1 at denison.edu>
  Date:   2019-08-12 (Mon, 12 Aug 2019)

  Changed paths:
    M ckan/lib/changes.py
    M ckan/tests/lib/test_changes.py

  Log Message:
  -----------
  Fix names of keys in tests

  Commit: 0231230e020782dd704ae289ba0be0edc30cb66e
      https://github.com/ckan/ckan/commit/0231230e020782dd704ae289ba0be0edc30cb66e
  Author: hayley-leblanc <leblan_h1 at denison.edu>
  Date:   2019-08-12 (Mon, 12 Aug 2019)

  Changed paths:
    M ckan/lib/changes.py
    M ckan/templates/snippets/changes/resource_extras.html
    M ckan/tests/lib/test_changes.py

  Log Message:
  -----------
  Fix keys used to check changes for org ownership and resource extras

  Commit: fe1513a2d37410dfc861cfc099b98d41665f05fe
      https://github.com/ckan/ckan/commit/fe1513a2d37410dfc861cfc099b98d41665f05fe
  Author: hayley-leblanc <leblan_h1 at denison.edu>
  Date:   2019-08-12 (Mon, 12 Aug 2019)

  Changed paths:
    M ckan/lib/changes.py
    M ckan/tests/lib/test_changes.py

  Log Message:
  -----------
  Add position to default fields, fix pep8 issues

  Commit: ceddd628dd46e4b8f4ebd72409a73cdf2ae61858
      https://github.com/ckan/ckan/commit/ceddd628dd46e4b8f4ebd72409a73cdf2ae61858
  Author: hayley-leblanc <leblan_h1 at denison.edu>
  Date:   2019-08-12 (Mon, 12 Aug 2019)

  Changed paths:
    M ckan/lib/helpers.py
    M ckan/tests/lib/test_changes.py

  Log Message:
  -----------
  Fix issues with resource extra tests

  Commit: 83a5755e877abbc67bfa95fadd08c0836e83a1f9
      https://github.com/ckan/ckan/commit/83a5755e877abbc67bfa95fadd08c0836e83a1f9
  Author: hayley-leblanc <leblan_h1 at denison.edu>
  Date:   2019-08-12 (Mon, 12 Aug 2019)

  Changed paths:
    M ckan/lib/changes.py
    M ckan/lib/helpers.py
    M ckan/tests/lib/test_changes.py

  Log Message:
  -----------
  Small fixes

  Commit: 30b85c7ad4d5d0d823a357e3941017c20ab5edb1
      https://github.com/ckan/ckan/commit/30b85c7ad4d5d0d823a357e3941017c20ab5edb1
  Author: hayley-leblanc <leblan_h1 at denison.edu>
  Date:   2019-08-13 (Tue, 13 Aug 2019)

  Changed paths:
    M ckan/lib/changes.py

  Log Message:
  -----------
  Fixes

  Commit: fe5205d9e212089357e230a3eb23cec920773978
      https://github.com/ckan/ckan/commit/fe5205d9e212089357e230a3eb23cec920773978
  Author: hayley-leblanc <leblan_h1 at denison.edu>
  Date:   2019-08-14 (Wed, 14 Aug 2019)

  Changed paths:
    M ckan/i18n/ckan.pot
    M ckan/templates/snippets/changes/author.html
    M ckan/templates/snippets/changes/author_email.html
    M ckan/templates/snippets/changes/delete_resource.html
    M ckan/templates/snippets/changes/extension_fields.html
    M ckan/templates/snippets/changes/extra_fields.html
    M ckan/templates/snippets/changes/license.html
    M ckan/templates/snippets/changes/maintainer.html
    M ckan/templates/snippets/changes/maintainer_email.html
    M ckan/templates/snippets/changes/name.html
    M ckan/templates/snippets/changes/new_file.html
    M ckan/templates/snippets/changes/new_resource.html
    M ckan/templates/snippets/changes/notes.html
    M ckan/templates/snippets/changes/org.html
    M ckan/templates/snippets/changes/private.html
    M ckan/templates/snippets/changes/resource_desc.html
    M ckan/templates/snippets/changes/resource_extras.html
    M ckan/templates/snippets/changes/resource_format.html
    M ckan/templates/snippets/changes/resource_name.html
    M ckan/templates/snippets/changes/tags.html
    M ckan/templates/snippets/changes/title.html
    M ckan/templates/snippets/changes/url.html
    M ckan/templates/snippets/changes/version.html

  Log Message:
  -----------
  Fix translatable strings in change templates

  Commit: 93fd3dc60bc73f483cd79ccc508e7ef3009b54d4
      https://github.com/ckan/ckan/commit/93fd3dc60bc73f483cd79ccc508e7ef3009b54d4
  Author: hayley-leblanc <leblan_h1 at denison.edu>
  Date:   2019-08-14 (Wed, 14 Aug 2019)

  Changed paths:
    M ckan/templates/snippets/changes/extension_fields.html

  Log Message:
  -----------
  Fix issue with extension field change summary HTML

  Commit: f9e538e47fd5ca6a50bf686cdb611c6a9c3d26d9
      https://github.com/ckan/ckan/commit/f9e538e47fd5ca6a50bf686cdb611c6a9c3d26d9
  Author: hayley-leblanc <31440954+hayley-leblanc at users.noreply.github.com>
  Date:   2019-08-14 (Wed, 14 Aug 2019)

  Changed paths:
    M ckan/templates/snippets/changes/extension_fields.html

  Log Message:
  -----------
  ACTUALLY fix extension fields HTML issue

  Commit: 4c01a3229d86a59f6197c84dd0a908331d1a88a1
      https://github.com/ckan/ckan/commit/4c01a3229d86a59f6197c84dd0a908331d1a88a1
  Author: David Read <david.read at hackneyworkshop.com>
  Date:   2019-09-05 (Thu, 05 Sep 2019)

  Changed paths:
    M ckan/tests/lib/test_changes.py

  Log Message:
  -----------
  Fix test_remove_org test, thanks to @smotornyuk

Compare: https://github.com/ckan/ckan/compare/c50374e52cef%5E...4c01a3229d86