[ckan-dev] highlight error in nav links

Wed Jan 12 23:23:45 UTC 2011

Hello,

The code path is definitely tested already in the functional tests.  To test
it properly (i.e emulate going through all possible menus and see if only
the correct ones were highlighted) would take a lot of work and not be
robust to ui changes.  So I would say its not worth testing it.

David

On Wed, Jan 12, 2011 at 8:46 PM, David Read <david.read at okfn.org> wrote:

> Hi David,
>
> Many thanks for this! This might be sufficiently non-trivial to be
> worth having a test for - what do you think?
>
> David
>
> On 12 January 2011 20:07, David Raznick <kindly at gmail.com> wrote:
> > Hello
> >
> > I have a patch for this defect http://ckan.org/ticket/870.  Its in the
> > bug_870_menu_items_not_selecting_correctly branch available at
> > https://bitbucket.org/kindly/ckan/changeset/9a1d6f55587b.
> > It basically allows you to specify certain actions to highlight on.
> >
> > David
> >
> >
> >
> > _______________________________________________
> > ckan-dev mailing list
> > ckan-dev at lists.okfn.org
> > http://lists.okfn.org/mailman/listinfo/ckan-dev
> >
> >
>
> _______________________________________________
> ckan-dev mailing list
> ckan-dev at lists.okfn.org
> http://lists.okfn.org/mailman/listinfo/ckan-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.okfn.org/pipermail/ckan-dev/attachments/20110112/a76f3a52/attachment-0001.html>