[ckan-dev] Commit policy

Tue Mar 15 15:09:56 UTC 2011

I'm up for greater discipline... But having said that, I'd quite like
to make the three-line change below, and I wonder if that, too, needs
a ticket and a branch?  Is there perhaps a slightly fuzzy area where
branches aren't necessary (e.g. changes that don't need a change to
tests)?

Seb



diff -r ff071cfc5472 ckan/lib/helpers.py

--- a/ckan/lib/helpers.py	Mon Mar 07 17:11:51 2011 +0000
+++ b/ckan/lib/helpers.py	Tue Mar 15 14:58:57 2011 +0000
@@ -113,7 +113,9 @@
     return unicode(truncate(plain, length=190, indicator='...',
whole_word=True))

 def icon_url(name):
-    return '/images/icons/%s.png' % name
+    from pylons import config
+    site_url = config.get('ckan.site_url', '')
+    return '%s/images/icons/%s.png' % (site_url, name)




On 15 March 2011 12:58, James Gardner <james_archive at 3aims.com> wrote:
> Yes, we should push for greater discipline.
>
> Please only commit to branches and only if there is a ticket. I know I've
> been breaking this rule too for my doc changes but I'll try harder not to as
> well.
>
> Cheers,
>
> James
>
>
> On 15/03/11 11:03, David Read wrote:
>>
>> In the past week it seems everyone (myself included) has been making
>> repeated commits to CKAN code without a branch or referencing tickets.
>> I'm flagging it because this isn't what we collectively decided to aim
>> for a few weeks ago. Are we comfortable with this or do people think
>> we should push for greater discipline in the process?
>>
>> David
>>
>> _______________________________________________
>> ckan-dev mailing list
>> ckan-dev at lists.okfn.org
>> http://lists.okfn.org/mailman/listinfo/ckan-dev
>
>
> _______________________________________________
> ckan-dev mailing list
> ckan-dev at lists.okfn.org
> http://lists.okfn.org/mailman/listinfo/ckan-dev
>



-- 
skype: seb.bacon
mobile: 07790 939224
land: 0207 183 9618
web: http://baconconsulting.co.uk


