[ckan-dev] repoze who - openID broken?

Fri Jun 8 10:14:59 UTC 2012

looking at ticket 2497 http://trac.ckan.org/ticket/2497

the issue (thanks adria) is in lib/repoze_patch.py, having fixed the issue
I thought I'd do some cleanups (unused imports, pep8 etc)

whilst doing this it is apparent that identify() used by openID would fail
in some circumstances because `chain` is not defined.  It may be that we
have not hit these circumstances.

anyhow the problem for me is that this is quite difficult to test
especially trying to work out all the combinations created by different
openID providers so I'm not going to fix this but someone else might.  If
so please use the  2497-lose-language-on-abort branch as I've done some
minor refactoring in that branch

Ultimately this feels another reason to either kill openID or do a proper
intergration

Toby
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.okfn.org/pipermail/ckan-dev/attachments/20120608/ffdf7deb/attachment.html>