[ckan-dev] pep8 mania

Fri Jun 22 10:22:30 UTC 2012

I've started committing each file manually for a few of them, which should make it less painful in future.
I think we'll NEVER get it done if we don't take the plunge and do it in reasonably big chunks (with individual commits).  

Doing controllers took a couple of hours, and I think if we each just did 2 hours on cleanup it'd make a huge difference.

Ross

On 22 Jun 2012, at 11:19, Toby Dacre wrote:

> regarding Ross' pep8 patches
> 
> https://github.com/okfn/ckan/pull/29/files
> 
> Whilst This is quite invasive and will probably cause the need for manual merges I think it might just be a good idea to take the plunge and merge it into master.
> 
> I think we all agree that this is beneficial to the code even if slightly painful.  I don't think we will ever have a particularly good time for these sort of patches and it seems silly to waste the work Ross has done here.
> 
> what do others think?
> 
> maybe we should do these patches on a more file by file basis?
> 
> Toby
> _______________________________________________
> ckan-dev mailing list
> ckan-dev at lists.okfn.org
> http://lists.okfn.org/mailman/listinfo/ckan-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.okfn.org/pipermail/ckan-dev/attachments/20120622/4a4e779c/attachment-0001.html>