[ckan-dev] 2939-orgs pull request

[Sean Hammond]

Hi Toby,

I've read through the pull request today:

https://github.com/okfn/ckan/pull/146/

Thanks so much for this work, I think you've done an incredible job to
produce this especially in the time given. It's a big patch but one
that is surprisingly easy to understand and produces a surprisingly
small amount of unease given the size of the patch.

I think David also wants to review it and think he should as you touched
some scary parts of the code that I don't know much about.

You really removed a lot of code, I like it!

I think the main thing that we need to do before we merge it (or after
we merge it but before we release 2.0) is at least add some functional
tests for the new orgs functionality, these could be based on the user
stories, I feel it's better the ckan team invests the time to do this
before releasing, rather than releasing and fixing the inevitable bugs
when users start running into them.

I'd also like to see create_test_data making some test orgs but the ckan
tests are in need of a big overhaul.

I'll put notes for specific small things in the pull request where we
can find them later.