[ckan-dev] DEVS PLEASE READ Re: Ckan Exceptions and translation

[Toby Dacre]

We agreed today that all Exceptions must be in English and _not_ translated.

this is because they are part of the code
we all need to be able to read stack traces
translators have enough to translate already

Do not accept any pull requests that include them
We also need to remove any we see in the code base

If you have added any please remove them asap

I will update the coding standards as soon as I can

The API output should also be English only too.

Thanks

Toby
On 17 April 2013 11:14, Adrià Mercader <adria.mercader at okfn.org> wrote:

> I'm generally +1 on not translating any exceptions, but as you say we
> then need to make sure that they are captured by the controllers or
> whatever before showing them on the frontend.
>
>
> Adrià
>
> On 16 April 2013 15:17, Toby Dacre <toby.okfn at gmail.com> wrote:
> > Hi,
> >
> > I see code like this
> >     `raise Exception(_('some error'))`
> >
> > I think these should be
> >     `raise Exception('some error')`
> >
> > In my view Exceptions are for developers and log files etc so we should
> not
> > be pushing the Exception message to the user.  By using _ our error logs
> > will be in the language of the user who had the error not in English like
> > the code base.  This make support much more difficult.
> >
> > This is a new thing that has started happening.  Can anyone justify this
> > change?  Can we stop doing it?
> >
> > Toby
> >
> > _______________________________________________
> > ckan-dev mailing list
> > ckan-dev at lists.okfn.org
> > http://lists.okfn.org/mailman/listinfo/ckan-dev
> > Unsubscribe: http://lists.okfn.org/mailman/options/ckan-dev
> >
>
> _______________________________________________
> ckan-dev mailing list
> ckan-dev at lists.okfn.org
> http://lists.okfn.org/mailman/listinfo/ckan-dev
> Unsubscribe: http://lists.okfn.org/mailman/options/ckan-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.okfn.org/pipermail/ckan-dev/attachments/20130418/c7acf6b2/attachment.html>