[ckan-dev] PDF Preview broken in CKAN 2.1

Thu Aug 15 14:39:09 UTC 2013

Hey,

We don't automatically minify vendor files and forgot to reminify the pdf.js file before the release. 

@Ralf, we'll fix this in the next patch release. For now, just remove the ckanext/pdfpreview/theme/public/vendor/pdfjs/pdf.js file and it should work as expected. Sorry about that. 

Cheers,
Dominik

On 15 Aug 2013, at 16:09, Vitor Baptista <vitor at vitorbaptista.com> wrote:

> Quickly looking into demo, it seems that pdfjs' minified version in
> https://github.com/okfn/ckan/blob/master/ckanext/pdfpreview/theme/public/vendor/pdfjs/pdf.min.js
> is
> broken. Looking in pdf.js' issues, it seems they had problems with
> minification already (https://github.com/mozilla/pdf.js/issues/2479). As
> our pdf.min.js version is 10 months old, while pdf.js is 2 months, I guess
> we should re-minify it.
> 
> Could you try to do it?
> 
> Dominik, does it make sense to you?
> 
> Vítor Baptista
> 
> Developer  |  http://vitorbaptista.com |
> LinkedIn<http://www.linkedin.com/in/vitorbaptista>|
> @vitorbaptista <http://twitter.com/vitorbaptista>
> 
> The Open Knowledge Foundation <http://okfn.org>
> 
> *Empowering through Open Knowledge*
> 
> http://okfn.org/  |  @okfn <http://twitter.com/okfn>  |  OKF on
> Facebook<https://www.facebook.com/OKFNetwork> |
> Blog <http://blog.okfn.org/>  |  Newsletter<http://okfn.org/about/newsletter/>
> 
> 
> 
> 2013/8/15 Ralf Krüdewagen <user66 at arcor.de>
> 
>> Hi,
>> 
>> after upgrading from CKAN 2.0.x to 2.1 the PDF Preview does not work any
>> more. The embedded PDF preview window appears, but the content of the PDF
>> doc is not shown. This happens with local and remote files.
>> 
>> Example on CKAN demo site:
>> 
>> http://demo.ckan.org/dataset/pdf-test/resource/5597e098-83bb-4ffd-835b-2e94688007b8
>> 
>> And on my site:
>> 
>> http://demo.offene-daten.me/dataset/pdf-test/resource/f725204e-297b-44dd-bd1f-69764e34618b
>> 
>> Any idea what can be done to fix this?
>> 
>> Cheers
>> Ralf
>> 
>> 
>> 
>> _______________________________________________
>> ckan-dev mailing list
>> ckan-dev at lists.okfn.org
>> http://lists.okfn.org/mailman/listinfo/ckan-dev
>> Unsubscribe: http://lists.okfn.org/mailman/options/ckan-dev
>> 
> _______________________________________________
> ckan-dev mailing list
> ckan-dev at lists.okfn.org
> http://lists.okfn.org/mailman/listinfo/ckan-dev
> Unsubscribe: http://lists.okfn.org/mailman/options/ckan-dev

Dominik Moritz
CKAN developer  |  skype: d.moritz  |  @doobly_doo
The Open Knowledge Foundation
Empowering through Open Knowledge
http://okfn.org/  |  @okfn  |  http://ckan.org  |  @CKANproject

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.okfn.org/pipermail/ckan-dev/attachments/20130815/fd969afb/attachment-0001.sig>