[ckan-dev] 2.1 Pull requests and issues status

Sean Hammond sean.hammond at okfn.org
Fri Jun 28 15:12:29 UTC 2013


> sean / nigel
> https://github.com/okfn/ckan/pull/997

@nigel, is this one ready for review again?

Also, people:

if an issue isn't assigned to me on GitHub, then I am no longer aware
that the issue exists! :)

The way I deal with github (and I suggest we do things in such a way
that we can all deal with it like this) is to look at the list of issues
assigned to me on my dashboard. If nothing's assigned to me then I
assume there's nothing that people are waiting on me for.

My medium-term memory melted years ago!

If you're reviewing a pull request and you finish your review and want
the submitter to do some changes -- assign the pull request back to
them.

Conversely if someone has reviewed your pull request and asked you to
make changes, and then you make those changes and want them to review it
again, assign the pull request back to them.

Or at least @mention them so they know they have to do something, but
generally I get way too much traffic on github so @mentions are easy to
miss.




More information about the ckan-dev mailing list