[ckan-dev] Broken action functions

Mon May 13 11:35:31 UTC 2013

On 13 May 2013 11:23, Nigel Babu <nigel.babu at okfn.org> wrote:
> Ah, that's what I missed. Does this means that the is_org flag in
> https://github.com/okfn/ckan/blob/master/ckan/logic/action/create.py#L456 is
> not needed at all?

It is there for the future also we might want to actually check the
group is an org at some point.  It can be safely left as is
>
> Nigel Babu
>
> Developer  |  @nigelbabu
>
> The Open Knowledge Foundation
>
> Empowering through Open Knowledge
>
> http://okfn.org/  |  @okfn  |  OKF on Facebook  |  Blog  |  Newsletter
>
>
> CKAN | http://ckan.org/ | @CKANproject | the world’s leading open-source
> data portal platform
>
>
> On 13 May 2013 14:40, Toby Dacre <toby.okfn at gmail.com> wrote:
>>
>> On 13 May 2013 05:56, Nigel Babu <nigel.babu at okfn.org> wrote:
>> > Hi!
>> >
>> > Did we at any point use `organization_member_create` and
>> > `organization_member_delete`? From what I can see, both of them don't
>> > work
>> > because `_group_or_org_member_create` and `_group_or_org_member_delete`
>> > respectively assume that they're creating a group and don't do anything
>> > for
>> > organizations. Is there something I'm missing?
>>
>> orgs are just a special type of group.  I believe it all works as expected
>> >
>> > I'm happy to fix this if this is indeed the case.
>> >
>> > Nigel Babu
>> >
>> > Developer  |  @nigelbabu
>> >
>> > The Open Knowledge Foundation
>> >
>> > Empowering through Open Knowledge
>> >
>> > http://okfn.org/  |  @okfn  |  OKF on Facebook  |  Blog  |  Newsletter
>> >
>> >
>> > CKAN | http://ckan.org/ | @CKANproject | the world’s leading open-source
>> > data portal platform
>> >
>> > _______________________________________________
>> > ckan-dev mailing list
>> > ckan-dev at lists.okfn.org
>> > http://lists.okfn.org/mailman/listinfo/ckan-dev
>> > Unsubscribe: http://lists.okfn.org/mailman/options/ckan-dev
>> >
>>
>>
>>
>> --
>> Toby Dacre
>>
>> The Open Knowledge Foundation
>>
>> Empowering through Open Knowledge
>> http://okfn.org/  |  @okfn
>>
>> _______________________________________________
>> ckan-dev mailing list
>> ckan-dev at lists.okfn.org
>> http://lists.okfn.org/mailman/listinfo/ckan-dev
>> Unsubscribe: http://lists.okfn.org/mailman/options/ckan-dev
>
>
>
> _______________________________________________
> ckan-dev mailing list
> ckan-dev at lists.okfn.org
> http://lists.okfn.org/mailman/listinfo/ckan-dev
> Unsubscribe: http://lists.okfn.org/mailman/options/ckan-dev
>


-- 
Toby Dacre

The Open Knowledge Foundation

Empowering through Open Knowledge
http://okfn.org/  |  @okfn