[kforge-user] Join Request Feature Patch

Wed Dec 22 16:06:40 UTC 2010

Hi Eitan,

I've tried this out now. It's all working and it's really great.

I've committed a changeset for the patch:
http://knowledgeforge.net/kforge/trac/changeset/1443

I'll try soon to add links in the emails and tests for the views.

Thank you very much for spending time adding this excellent feature!

All best wishes,

John.

John Bywater wrote:
> Hi Eitan,
> 
> Wow! That's amazing....
> 
> I'll fold it into the code ASAP. ;-)
> 
> Thank you very much. Best wishes,
> 
> John.
> 
> 
> 
> 
> Eitan Marder-Eppstein wrote:
>> Hey John,
>>
>> So I took a little time this afternoon and finished up the join project
>> feature. I only added the one test we talked about, but that at least
>> passes, and its working well in the browser for me.
>>
>> Features:
>>
>> * A join button displays on the main project page for users who are not
>> members of the project or pending members
>> * Clicking the button sends an e-mail to all project admins as well as
>> updating the pending members table for the project
>> * The member management page for each project now shows a list of pending
>> members that admins can manage
>> * Approval or rejection results in an e-mail being sent to the 
>> relevant user
>> (One thing I didn't add that might be really easy for you to do in the
>> e-mails is a link to the correct pages on the site. Something like "click
>> here to see the request." I didn't look hard, but I didn't find where to
>> pull that from right away, I imagine it probably lies somewhere in the
>> dictionary.)
>>
>> So, there you have it. Pretty simple. I tried to handle the edge cases I
>> could think of, but I'm sure I missed something.
>>
>> I guess play around with it and let me know what you think and 
>> if/where it
>> breaks.
>>
>> Hope all is well,
>>
>> Eitan
>>
>>
> 