[okfn-labs] Code review exchange

Wed Jun 5 10:31:55 UTC 2013

Hi all,

OpenSpending is a platform that a lot of users (other sites) rely on so
we care deeply about quality assurance. One of the things we do as part
of QA is code review. A developer should never merge his/her changes
into master unless somebody else has looked over the changes and given
them a "go".

For bigger changes we can also deploy the changes to our staging server
so code reviewers can test them on a live site as well.

Now, this makes the contribution process a bit longer. You contribute,
then you wait, then somebody reviews when that developer has time and
your changes (hopefully) get committed. If you need to make some more
changes you have to go back in line after you commit them.

Therefore we need many code reviewers to keep the process fast. We do
not make any requirements of technical knowledge about OpenSpending but
the code reviewer should be proficient in both Python and Javascript
(and web development in general). The job of the code reviewer is just
to ask a lot of questions if there's any doubt as to why things are
implemented in a certain way.

So I want to make a proposal. Let's do "collaborative QA", we do code
review exchange. Who on this list are willing to become a code reviewers
for OpenSpending? In return I will become a code reviewer for their
projects.

-- 

Tryggvi Björgvinsson

Technical Lead, OpenSpending

The Open Knowledge Foundation <http://okfn.org>

/Empowering through Open Knowledge/

http://okfn.org/ | @okfn <http://twitter.com/OKFN> | OKF on Facebook
<https://facebook.com/OKFNetwork> | Blog <http://blog.okfn.org/> |
Newsletter <http://okfn.org/about/newsletter>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.okfn.org/pipermail/okfn-labs/attachments/20130605/082d74c3/attachment-0001.html>