[annotator-dev] running annotator tests

Sat Apr 27 15:40:23 UTC 2013

Yes, thanks guys. I don't know why I just jumped to running
tools/test_phantom without doing test/build first -- like it says in
the HACKING.markdown. I'm not sure I'm qualified to comment re: make
vs redo since I couldn't read the already simple documentation :-D

//Ed

On Sat, Apr 27, 2013 at 9:21 AM, Nick Stenning <nick at whiteink.com> wrote:
> I hope you've got that working now Ed?
>
> It's perhaps not entirely clear that the tests run against the generated
> JavaScript and so the files in ./lib need building before the tests will
> work.
>
> And as for whether we want to replace redo with a Makefile...
>
> ...as much as I love redo (I really do) I think if I'm honest it's probably
> a bit of a conceit. It adds overhead for people who really don't care about
> build systems.
>
> So, if you fancy replacing it with one or two Makefiles, Randall, you have
> my blessing.
>
> -N
>
>
> On Thu, Apr 25, 2013 at 10:33 PM, Randall Leeds <tilgovi at hypothes.is> wrote:
>>
>> For easier-to-read output you can do "./tools/test_phantom -R dot" or
>> simply "make test".
>>
>> I know Nick talked to me at our meetup about maybe removing the redo
>> tool and going for normal make. If we want to do this I'm happy to
>> write the Makefile which would have the proper rules so that "make
>> test" automatically ensures an up-to-date build first.
>>
>> On Thu, Apr 25, 2013 at 2:31 PM, Randall Leeds <tilgovi at hypothes.is>
>> wrote:
>> > Did you build the JS yet?
>> >
>> > ./tools/build (included in my most recent pushes) or ./tools/watch
>> > (for live updating)
>> >
>> > Then you should be able to test_phantom as you wrote.
>> >
>> > On Thu, Apr 25, 2013 at 2:59 AM, Ed Summers <ehs at pobox.com> wrote:
>> >> Hi all,
>> >>
>> >> I'm just getting up to speed with writing a plugin to support some
>> >> annotator-store work I did for cross-format-annotations [1] (more on
>> >> that later).
>> >>
>> >> I love seeing that effort was made to test the annotator (makes my
>> >> life easier). But I'm a bit unclear on how to run the test suite,
>> >> perhaps I'm doing something wrong?
>> >>
>> >>   % tools/test_phantom
>> >>   0 tests complete (1 ms)
>> >>
>> >> I'm testing with okfn's annotator-store [2] and phantomjs v1.8.2. Any
>> >> help you can provide would be greatly appreciated!
>> >>
>> >> //Ed
>> >>
>> >> [1] https://github.com/hypothesis/h/wiki/cross-format-annotations
>> >> [2] https://github.com/okfn/annotator
>> >>
>> >> _______________________________________________
>> >> annotator-dev mailing list
>> >> annotator-dev at lists.okfn.org
>> >> http://lists.okfn.org/mailman/listinfo/annotator-dev
>> >> Unsubscribe: http://lists.okfn.org/mailman/options/annotator-dev
>>
>> _______________________________________________
>> annotator-dev mailing list
>> annotator-dev at lists.okfn.org
>> http://lists.okfn.org/mailman/listinfo/annotator-dev
>> Unsubscribe: http://lists.okfn.org/mailman/options/annotator-dev
>
>