[ckan-changes] [ckan/ckan] 6ad708: [#2037] Make resource_create auth work against pac...

Tue Feb 10 14:12:36 UTC 2015

  Branch: refs/heads/release-v2.1.4
  Home:   https://github.com/ckan/ckan
  Commit: 6ad7082c6529bc42fb288f14c5c6428e29ac5922
      https://github.com/ckan/ckan/commit/6ad7082c6529bc42fb288f14c5c6428e29ac5922
  Author: amercader <amercadero at gmail.com>
  Date:   2015-02-10 (Tue, 10 Feb 2015)

  Changed paths:
    M ckan/logic/auth/create.py

  Log Message:
  -----------
  [#2037] Make resource_create auth work against package_update

Right now it was deferring to package_create, which doesn't make much
sense. Basically if you can update this particular dataset, you should
be able to add a resource to it. Added auth tests.

Also fixed the authorization for resource views creation. This is being
fully tested on #1852

Conflicts:
	ckan/logic/auth/create.py
	ckan/new_tests/logic/auth/test_create.py

  Commit: cf518358eabbe70f7a44726be10a8c9fe81e36b8
      https://github.com/ckan/ckan/commit/cf518358eabbe70f7a44726be10a8c9fe81e36b8
  Author: amercader <amercadero at gmail.com>
  Date:   2015-02-10 (Tue, 10 Feb 2015)

  Changed paths:
    M ckan/logic/action/create.py

  Log Message:
  -----------
  [#2037] Don't remove package_id before resource_create auth check

I didn't find any good reason as to why it was being done, and it
prevents `resource_create` auth to check authorization against the
dataset.

Added action tests

Conflicts:
	ckan/logic/action/create.py
	ckan/new_tests/logic/action/test_create.py

  Commit: a37213d7a65036aa87783c0d2b0fbacd17c4ca17
      https://github.com/ckan/ckan/commit/a37213d7a65036aa87783c0d2b0fbacd17c4ca17
  Author: joetsoi <joe.yeung.tsoi at gmail.com>
  Date:   2015-02-10 (Tue, 10 Feb 2015)

  Changed paths:
    M ckanext/datastore/plugin.py

  Log Message:
  -----------
  [#1374] fix datastore _read_connection_has_correct_privileges

remove the read connection, and use the write connection with the
username of the read connection to test if the priviliges are correct

  Commit: 5c30bb6f541a97e8ce242c793f54ba10b51f8697
      https://github.com/ckan/ckan/commit/5c30bb6f541a97e8ce242c793f54ba10b51f8697
  Author: joetsoi <joe.yeung.tsoi at gmail.com>
  Date:   2015-02-10 (Tue, 10 Feb 2015)

  Changed paths:
    M ckanext/datastore/plugin.py

  Log Message:
  -----------
  [#1374] refactor datastore _read_connection_has_correct_privileges()

 * remove nested try statement
 * use make_url instead of splicing the string for _get_db_url()

  Commit: 8cdc14b2879bd51273de42537bf6998868bb794a
      https://github.com/ckan/ckan/commit/8cdc14b2879bd51273de42537bf6998868bb794a
  Author: joetsoi <joe.yeung.tsoi at gmail.com>
  Date:   2015-02-10 (Tue, 10 Feb 2015)

  Changed paths:
    M ckanext/datastore/plugin.py

  Log Message:
  -----------
  [#1374] add host and port to _get_db_from_url

  Commit: ee11f1061959d529f69a8bfcc701bf5e1b3d953c
      https://github.com/ckan/ckan/commit/ee11f1061959d529f69a8bfcc701bf5e1b3d953c
  Author: joetsoi <joe.yeung.tsoi at gmail.com>
  Date:   2015-02-10 (Tue, 10 Feb 2015)

  Changed paths:
    M ckanext/datastore/plugin.py

  Log Message:
  -----------
  [#1374] datastore:rename variable to avoid confusing name clash

  Commit: 4c762314c3c8c12d3883c5126aaf71f0ec96a8f1
      https://github.com/ckan/ckan/commit/4c762314c3c8c12d3883c5126aaf71f0ec96a8f1
  Author: joetsoi <joe.yeung.tsoi at gmail.com>
  Date:   2015-02-10 (Tue, 10 Feb 2015)

  Changed paths:
    M ckanext/datastore/plugin.py

  Log Message:
  -----------
  [#1374] datastore:use bind params instead of string formatting

Compare: https://github.com/ckan/ckan/compare/c37595d6d805...4c762314c3c8