[ckan-changes] [ckan/ckan] 389da3: [#2037] Make resource_create auth work against pac...

Tue Feb 10 14:12:44 UTC 2015

  Branch: refs/heads/release-v2.2.2
  Home:   https://github.com/ckan/ckan
  Commit: 389da398aa115988e4f01c2b93eeba7c89565272
      https://github.com/ckan/ckan/commit/389da398aa115988e4f01c2b93eeba7c89565272
  Author: amercader <amercadero at gmail.com>
  Date:   2015-02-10 (Tue, 10 Feb 2015)

  Changed paths:
    M ckan/logic/auth/create.py
    M ckan/new_tests/logic/auth/test_create.py

  Log Message:
  -----------
  [#2037] Make resource_create auth work against package_update

Right now it was deferring to package_create, which doesn't make much
sense. Basically if you can update this particular dataset, you should
be able to add a resource to it. Added auth tests.

Also fixed the authorization for resource views creation. This is being
fully tested on #1852

Conflicts:
	ckan/logic/auth/create.py

  Commit: 42f3423f3f61bbbc70dce7195ede125bb589e316
      https://github.com/ckan/ckan/commit/42f3423f3f61bbbc70dce7195ede125bb589e316
  Author: amercader <amercadero at gmail.com>
  Date:   2015-02-10 (Tue, 10 Feb 2015)

  Changed paths:
    M ckan/new_tests/logic/auth/test_create.py

  Log Message:
  -----------
  [#2037] PEP8

  Commit: b6a5f2afb2b1a600d62dee1983e31273eb7bc588
      https://github.com/ckan/ckan/commit/b6a5f2afb2b1a600d62dee1983e31273eb7bc588
  Author: amercader <amercadero at gmail.com>
  Date:   2015-02-10 (Tue, 10 Feb 2015)

  Changed paths:
    M ckan/logic/action/create.py
    M ckan/new_tests/logic/action/test_create.py

  Log Message:
  -----------
  [#2037] Don't remove package_id before resource_create auth check

I didn't find any good reason as to why it was being done, and it
prevents `resource_create` auth to check authorization against the
dataset.

Added action tests

Conflicts:
	ckan/logic/action/create.py
	ckan/new_tests/logic/action/test_create.py

  Commit: fd14420959970bb2d93740858fee9d68833696c3
      https://github.com/ckan/ckan/commit/fd14420959970bb2d93740858fee9d68833696c3
  Author: joetsoi <joe.yeung.tsoi at gmail.com>
  Date:   2015-02-10 (Tue, 10 Feb 2015)

  Changed paths:
    M ckanext/datastore/plugin.py

  Log Message:
  -----------
  [#1374] fix datastore _read_connection_has_correct_privileges

remove the read connection, and use the write connection with the
username of the read connection to test if the priviliges are correct

  Commit: 7944df7123ebaea2945a2b5532d57ce6e739939e
      https://github.com/ckan/ckan/commit/7944df7123ebaea2945a2b5532d57ce6e739939e
  Author: joetsoi <joe.yeung.tsoi at gmail.com>
  Date:   2015-02-10 (Tue, 10 Feb 2015)

  Changed paths:
    M ckanext/datastore/plugin.py

  Log Message:
  -----------
  [#1374] refactor datastore _read_connection_has_correct_privileges()

 * remove nested try statement
 * use make_url instead of splicing the string for _get_db_url()

  Commit: fa0011137fc9e945a9418c8659c40965a4d5db65
      https://github.com/ckan/ckan/commit/fa0011137fc9e945a9418c8659c40965a4d5db65
  Author: joetsoi <joe.yeung.tsoi at gmail.com>
  Date:   2015-02-10 (Tue, 10 Feb 2015)

  Changed paths:
    M ckanext/datastore/plugin.py

  Log Message:
  -----------
  [#1374] add host and port to _get_db_from_url

  Commit: 693564834290c4e4899d4728816187cb49cf91b3
      https://github.com/ckan/ckan/commit/693564834290c4e4899d4728816187cb49cf91b3
  Author: joetsoi <joe.yeung.tsoi at gmail.com>
  Date:   2015-02-10 (Tue, 10 Feb 2015)

  Changed paths:
    M ckanext/datastore/plugin.py

  Log Message:
  -----------
  [#1374] datastore:rename variable to avoid confusing name clash

  Commit: 0cf8a2cab6aa027efe695265c5a14c529e96f279
      https://github.com/ckan/ckan/commit/0cf8a2cab6aa027efe695265c5a14c529e96f279
  Author: joetsoi <joe.yeung.tsoi at gmail.com>
  Date:   2015-02-10 (Tue, 10 Feb 2015)

  Changed paths:
    M ckanext/datastore/plugin.py

  Log Message:
  -----------
  [#1374] datastore:use bind params instead of string formatting

Compare: https://github.com/ckan/ckan/compare/bc1fcf4d63ef...0cf8a2cab6aa