[ckan-changes] [ckan/ckan] 9bb37f: Pad Groups and Org names from factories with zeros

GitHub noreply at github.com
Fri Aug 26 11:27:34 UTC 2016


  Branch: refs/heads/release-v2.4.4
  Home:   https://github.com/ckan/ckan
  Commit: 9bb37f406483b1da74a15f6d3b46fbf8a8b7e68c
      https://github.com/ckan/ckan/commit/9bb37f406483b1da74a15f6d3b46fbf8a8b7e68c
  Author: Knut Hühne <knut at k-nut.eu>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M ckan/tests/factories.py

  Log Message:
  -----------
  Pad Groups and Org names from factories with zeros

The test in ckan/tests/controllers/test_group.py would sometimes fail
when run in an unfortunate order. The
`test_page_thru_list_of_orgs_preserves_sort_order` and
`test_page_thru_list_of_groups_preserves_sort_order` would fail because
some organizations had already been created by oyher tests and the numbering would
start a 5 instead of 1. And because the sorting was done via strings (so
`Group 5` came after `Group 31` the test would fail. By always padding
them with zeros this should not happend anymore and make the tests more
stable (So it is `Group 05` now).


  Commit: a5edb9f754e499a34f59a1141c53d403ef4e9132
      https://github.com/ckan/ckan/commit/a5edb9f754e499a34f59a1141c53d403ef4e9132
  Author: Knut Hühne <knut at k-nut.eu>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M ckan/tests/factories.py

  Log Message:
  -----------
  Pad all things that come from factories with zeros


Compare: https://github.com/ckan/ckan/compare/8b4c0b9e3f45...a5edb9f754e4


More information about the ckan-changes mailing list