[ckan-changes] [ckan/ckan] b750c4: Pad Groups and Org names from factories with zeros

GitHub noreply at github.com
Fri Aug 26 11:27:49 UTC 2016


  Branch: refs/heads/release-v2.5.3
  Home:   https://github.com/ckan/ckan
  Commit: b750c44cf5c2a9ef343b60c1563aac9904846648
      https://github.com/ckan/ckan/commit/b750c44cf5c2a9ef343b60c1563aac9904846648
  Author: Knut Hühne <knut at k-nut.eu>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M ckan/tests/factories.py

  Log Message:
  -----------
  Pad Groups and Org names from factories with zeros

The test in ckan/tests/controllers/test_group.py would sometimes fail
when run in an unfortunate order. The
`test_page_thru_list_of_orgs_preserves_sort_order` and
`test_page_thru_list_of_groups_preserves_sort_order` would fail because
some organizations had already been created by oyher tests and the numbering would
start a 5 instead of 1. And because the sorting was done via strings (so
`Group 5` came after `Group 31` the test would fail. By always padding
them with zeros this should not happend anymore and make the tests more
stable (So it is `Group 05` now).


  Commit: 8e69540f3a235ddb554b56c2d9cb547321d0aabc
      https://github.com/ckan/ckan/commit/8e69540f3a235ddb554b56c2d9cb547321d0aabc
  Author: Knut Hühne <knut at k-nut.eu>
  Date:   2016-08-26 (Fri, 26 Aug 2016)

  Changed paths:
    M ckan/tests/factories.py

  Log Message:
  -----------
  Pad all things that come from factories with zeros


Compare: https://github.com/ckan/ckan/compare/cb8d2f57d260...8e69540f3a23


More information about the ckan-changes mailing list