[ckan-dev] UX bugs

Wed Nov 23 10:28:31 UTC 2011

Hi,

These two templates are fixed now in the master branch. We just need
to be explicit about the controller, action and id being passed to url
or url_for now.

So, in this case, url_for(controller='package', id=None) had to change
to url_for(controller='package', action='index').

Cheers,
John

On 22 November 2011 23:55, Tom Rees <zephod at gmail.com> wrote:
> Again, we really need to generate some javascript tests (which will be part
> of a separate testing framework I think).
> Yep its entirely down to the map.explicit = True line. Go to create a
> dataset, or to create a group - you'll see the suggested URL is now some
> funny kind of querystring rather than /dataset/your-name.
>
> On Tue, Nov 22, 2011 at 8:32 PM, John Glover <john.glover at okfn.org> wrote:
>>
>> Hi Tom,
>>
>> This is most likely due to the change of map.explicit to True in the
>> routing file. Where exactly is the problem? Tests are passing.
>>
>> Cheers,
>> John
>>
>> On 22 November 2011 19:48, Tom Rees <zephod at gmail.com> wrote:
>> > Thanks for pointing this out, this is another merge gone awry from
>> > before&after the refactor of class names. Trivial to fix. We should make
>> > JS
>> > tests a high priority task, because the JS codebase now has a fairly
>> > stable
>> > core.
>> > I've summarised this glitch & the fixes, and another pointed out by
>> > amercader in chat, in a ticket: http://trac.ckan.org/ticket/1482
>> > As I've fixed them I've come across another oddity, that the output of
>> > h.url_for() has changed. John, could you look into this?
>> >
>> > On Tue, Nov 22, 2011 at 4:55 PM, David Read <david.read at okfn.org> wrote:
>> >>
>> >> Tom,
>> >>
>> >> The CKAN "Add a dataset" is pretty confusing because the name field is
>> >> not automatically generated from the title any more. You mentioned
>> >> some Javascript tests before - where are the tests for this function?
>> >>
>> >> Also, the license is not displayed any more, unless there are
>> >> resources(!) e.g.
>> >> http://test.ckan.net/dataset/dtest#section-basic-information is OGL,
>> >> but that's not shown.
>> >>
>> >> David
>> >
>> >
>
>