[ckan-dev] breaking extensions

[Toby Dacre]

For what it's worth the current disqus plugin appears to work

i'm going to add a config option

disqus.method = filter | helper_function

I'll think about a better general solution

toby

On 18 April 2012 11:58, Toby Dacre <toby.okfn at gmail.com> wrote:

> In theory it does I still need to signup to disqus to actual finish my
> testing but it should.
> The main issue is that it changes how it is added to the template so it
> will break existing templates
>
> On 18 April 2012 11:55, John Glover <john.glover at okfn.org> wrote:
>
>> Does it currently work on 1.6? If so then you could also just create a
>> 1.6 tag/branch and update master for 1.7.
>>
>> John
>>
>> On 18 April 2012 11:50, Toby Dacre <toby.okfn at gmail.com> wrote:
>> > Hi,
>> >
>> > I'm updating the ckanext-disqus extension.  I'd like to use the new
>> > ITemplateHelpers interface but this means it will require can 1.7 to
>> work.
>> > The main change is from using a genshi filter to using a helper
>> function.
>> >
>> > Options
>> >
>> > 1) just break stuff
>> > 2) create as new extension
>> > 3) try to determine version of ckan and change behaviour
>> > 4) use a config option to change behaviour
>> >
>> > to me option 4 seems the best option any thoughts?
>> >
>> > Toby
>> >
>> > _______________________________________________
>> > ckan-dev mailing list
>> > ckan-dev at lists.okfn.org
>> > http://lists.okfn.org/mailman/listinfo/ckan-dev
>> >
>>
>> _______________________________________________
>> ckan-dev mailing list
>> ckan-dev at lists.okfn.org
>> http://lists.okfn.org/mailman/listinfo/ckan-dev
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.okfn.org/pipermail/ckan-dev/attachments/20120418/b5f7178f/attachment-0001.html>