[ckan-dev] breaking extensions

[Rufus Pollock]

Hi Toby,

May be too late to help but I'm pretty sure no-one is using current
disqus plugin. I only upgraded it to work with 1.6 about a month ago
and had not announced that properly yet as was waiting for production
testing on DataHub. Thus, I think you can upgrade with impunity (which
also means we don't need to introduce a new config option -- always a
good thing).

Rufus

On Wednesday, 18 April 2012, Toby Dacre wrote:
>
> For what it's worth the current disqus plugin appears to work
>
> i'm going to add a config option
>
> disqus.method = filter | helper_function
>
> I'll think about a better general solution
>
> toby
>
> On 18 April 2012 11:58, Toby Dacre <toby.okfn at gmail.com> wrote:
>>
>> In theory it does I still need to signup to disqus to actual finish my testing but it should.
>> The main issue is that it changes how it is added to the template so it will break existing templates
>>
>> On 18 April 2012 11:55, John Glover <john.glover at okfn.org> wrote:
>>>
>>> Does it currently work on 1.6? If so then you could also just create a
>>> 1.6 tag/branch and update master for 1.7.
>>>
>>> John
>>>
>>> On 18 April 2012 11:50, Toby Dacre <toby.okfn at gmail.com> wrote:
>>> > Hi,
>>> >
>>> > I'm updating the ckanext-disqus extension.  I'd like to use the new
>>> > ITemplateHelpers interface but this means it will require can 1.7 to work.
>>> > The main change is from using a genshi filter to using a helper function.
>>> >
>>> > Options
>>> >
>>> > 1) just break stuff
>>> > 2) create as new extension
>>> > 3) try to determine version of ckan and change behaviour
>>> > 4) use a config option to change behaviour
>>> >
>>> > to me option 4 seems the best option any thoughts?
>>> >
>>> > Toby
>>> >
>>> > _______________________________________________
>>> > ckan-dev mailing list
>>> > ckan-dev at lists.okfn.org
>>> > http://lists.okfn.org/mailman/listinfo/ckan-dev
>>> >
>>>
>>> _______________________________________________
>>> ckan-dev mailing list
>>> ckan-dev at lists.okfn.org
>>> http://lists.okfn.org/mailman/listinfo/ckan-dev
>>
>>
>