[ckan-dev] Delete parse_rfc_2822_date()?

Wed Apr 18 17:10:39 UTC 2012

I'm to blame for this.  It's needed by the qa extension for reading
timestamps from http headers.

I'll look into why it's failing: whether it's the tests or not.

 - Ian.

On 18 April 2012 18:04, Sean Hammond <sean.hammond at okfn.org> wrote:

> Does anyone mind if I delete the parse_rfc_2822_date() function from
> helpers.py? These two tests for the function:
>
> ckan.tests.lib.test_helpers.TestHelpers.test_parse_rfc_2822_gmt_case
> ckan.tests.lib.test_helpers.TestHelpers.test_parse_rfc_2822_with_offset
>
> have been failing on master in some timezones. They fail for me and on
> Jenkins (both in Germany) but they pass on my linode and for some other
> ckan devs (located in the UK).
>
> I'm not sure who's wrong - the function or the tests. The function is
> not used anywhere in CKAN core, except by the tests.
>
> (I really want to see all tests passing on master on jenkins.)
>
> _______________________________________________
> ckan-dev mailing list
> ckan-dev at lists.okfn.org
> http://lists.okfn.org/mailman/listinfo/ckan-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.okfn.org/pipermail/ckan-dev/attachments/20120418/26ce8cf7/attachment-0001.html>