[ckan-dev] Code sprawl

Sean Hammond sean.hammond at okfn.org
Wed Aug 1 11:15:00 UTC 2012


> there are 7 templates arranged as follows
> 
> templates_new/ckanext/qa/
> |-- dataset
> |   |-- broken_resource_links
> |   |   `-- index.html
> |   |-- five_stars
> |   |   `-- index.html
> |   `-- index.html
> |-- index.html
> `-- organisation
>     |-- broken_resource_links
>     |   |-- index.html
>     |   `-- organisation.html
>     `-- index.html

It does seem a bit unnecessary.
    
> there are 6 controllers in 6 files including this gem
> 
> base.py
> -----------
> from ckan.lib.base import BaseController
> 
> class QAController(BaseController):
>     pass

I really hate this sort of thing (there's a lot of similar stuff in the
ckan tests as well).

> This just seems to be creating files just for the sake of it and makes
> working with the code a pain.  Is this just me who thinks this?  Personally
> I'd just like to clean this all up whilst I'm looking at it.

I say clean it up!




More information about the ckan-dev mailing list