[ckan-dev] Trac ticket refs in commit messages

Fri Jun 1 11:32:10 UTC 2012

On 1 June 2012 12:22, Aron Carroll <aron.carroll at okfn.org> wrote:

> I'm generally for this as I think the ticket reads better,

for what? ticket numbers at the end?

but if
> keeping the ticket number at the start helps Adrià out then I'm good
> with that too.
>

I like the
#1234 amazing commit message

I'm not sure that closes #1234 is actually of any value due to our code
review being needed before closing tickets so closing is not caused by a
commit but a merge

>
> Cheers,
> Aron
>
> On 31 May 2012, at 20:54, Adrià Mercader wrote:
>
> > On one hand I perhaps prefer having all ticket numbers at the start of
> > the commit message, but I think the ability to close or refer to trac
> > tickets is really cool, so I'm happy if everyone else is.
> > Also if all devs update the changelog it will be less important to go
> > through the commit list on each release
> >
> >
> > Adrià
> >
> > On 31 May 2012 18:57, Sean Hammond <sean.hammond at okfn.org> wrote:
> >> Speaking to Adria especially, what do you think of this commit message
> >> stuff I added to the coding standards?
> >>
> >> http://docs.ckan.org/en/latest/coding-standards.html
> >>
> >> It changes the syntax for referring to trac tickets from the [#123] at
> >> the start of the first line to stuff like "closes #123", "see #123" etc.
> >> anywhere in the commit message. It's the syntax used by the github-trac
> >> plugin. Not tested yet as I won't install the plugin until trac is
> >> updated
> >>
> >> _______________________________________________
> >> ckan-dev mailing list
> >> ckan-dev at lists.okfn.org
> >> http://lists.okfn.org/mailman/listinfo/ckan-dev
> >
> > _______________________________________________
> > ckan-dev mailing list
> > ckan-dev at lists.okfn.org
> > http://lists.okfn.org/mailman/listinfo/ckan-dev
>
>
> _______________________________________________
> ckan-dev mailing list
> ckan-dev at lists.okfn.org
> http://lists.okfn.org/mailman/listinfo/ckan-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.okfn.org/pipermail/ckan-dev/attachments/20120601/06475f0e/attachment-0001.html>