[ckan-dev] User Read tabs css not in primer

Tue Nov 13 15:15:56 UTC 2012

> Ok so can we change the main nav to be like that?
Please do. Change that branch and I'll update the CSS.
> This will get changed because it makes sense (only for new style templates) we want to aim for clarity in our code
> 
> As noted on the branch I'm cleaning up the links (so I can add new sections to user profile/dashboard) and also this will clean the breadcrumbs
> 
> are you happy with that?
Sure.

-- 
John Martin
Front End Developer
ckan.org (http://ckan.org)

On Tuesday, 13 November 2012 at 15:07, Toby Dacre wrote:

> 
> 
> On 13 November 2012 14:58, John Martin <john.martin.okfn at gmail.com (mailto:john.martin.okfn at gmail.com)> wrote:
> > Hi,
> > 
> > As per my earlier email I've setup a branch to see any changes mentioned:
> > 
> > https://github.com/okfn/ckan/tree/3016-template-tweaks 
> > > The tabs used in /user/<name> are not in the primer /testing/primer  it would be good if they were there for easy browser testing etc
> > 
> > 
> > 
> > This has been added.
> > > also is it possible to change the active tab so that the html would be
> > > 
> > > <li>
> > > <a class='active'>...</a>
> > > </li>
> > > 
> > > rather than
> > > 
> > > <li class="active">
> > > <a class="active">...</a>
> > > </li>
> > I'd like to change all the relevant HTML to match the bootstrap (and my personal preference) way of doing things:
> > 
> > <li class="active"><a /></li>
> > 
> > All other cases of navs within CKAN 2.0 are done like this (apart from the main nav). 
> Ok so can we change the main nav to be like that?
> 
> I'm happy to change the generating code that way we are consistent 
> > 
> > We have the double class="active" on the dom elements because the <a class="active" /> get's applied within the `h.link_for()` method. Also in order to change the main nav to have the correct class convention would mean a change to `link_for`, which I think is a little unnecessary and I don't know the full implications on changing something like that. 
> 
> This will get changed because it makes sense (only for new style templates) we want to aim for clarity in our code
> 
> As noted on the branch I'm cleaning up the links (so I can add new sections to user profile/dashboard) and also this will clean the breadcrumbs
> 
> are you happy with that?
>  
> > 
> > On the other hand to do it your new suggested way we would have to re-build how bootstrap handles it's `nav li.active a` conventions into `nav li a.active`. I don't feel that forking bootstrap in order to handle a small change like this is necessary though. 
> > 
> > Cheers,
> > 
> > -- 
> > John Martin
> > Front End Developer
> > ckan.org (http://ckan.org)
> > 
> > 
> > On Tuesday, 13 November 2012 at 11:30, Toby Dacre wrote:
> > 
> > > John,
> > > 
> > > The tabs used in /user/<name> are not in the primer /testing/primer  it would be good if they were there for easy browser testing etc
> > > 
> > > also is it possible to change the active tab so that the html would be
> > > 
> > > <li>
> > > <a class='active'>...</a>
> > > </li>
> > > 
> > > rather than
> > > 
> > > <li class="active">
> > > <a class="active">...</a>
> > > </li>
> > > 
> > > as this would then match the main nav html and simplify some of the code
> > > 
> > > please let me know
> > > cheers
> > > Toby
> > > 
> > 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.okfn.org/pipermail/ckan-dev/attachments/20121113/6a476e0f/attachment-0001.html>