[ckan-dev] master and minified files

[Toby Dacre]

On 25 February 2013 09:29, Sean Hammond <sean.hammond at okfn.org> wrote:

> The release process says that we update the minified files on release
> branches before a release, and these minified files then get merged back
> into master:
>
> https://github.com/okfn/ckan/wiki/Release-Process
>

This feels a little wrong to me.  Because then master has minified files
that are out of sync with the actual .js/.css files so running with and
without debug on/off gives different results for the front end.
it would seem to me that we should run `paster front-end-build` on master
when we change css/js like we do with the less changes currently (even if
we run bin/less to do that)

Release branches should also update the minified/less on those branches.
Does this cause us any issues?



> It says nothing about core extensions but I would guess the paster
> minify command in those instructions should be modified to include the
> core extensions too.
>
> On 25/02/13 09:46, Toby Dacre wrote:
> > Hi,
> >
> > This has been discussed before but I've forgotten if we agreed on
> anything.
> >
> > The issue is about the minified .js and .css files in ckan.
> >
> > My understanding is that following a bug with semicolons (why are we
> > using .js files by people who think semicolons are optional?) we are
> > updating minified vendor files when we update these libs.  Any ckan
> > minification (via paster) will ignore dirs called vendor and any sub
> dirs.
> >
> > `paster minify <path>` will minify a dir and it's sub dirs but ignore
> > 'vendor'
> >
> > issues
> >
> > do we include the minified files in non-release branches?
> > - personally I think we should but they should only get updated in
> > master - in much the same way as main.css
> > - some people have objected to this
> >
> > do we include the minified files in release branches?
> > - if we do this we have problems around .gitignore files (imho)
> >
> > we need to make sure the decision we make also takes core extensions
> > into account
> > - currently `paster front-end-build` only worries about ckan/public/base
> > - it also generates .css and some .js files used in translations
> >
> > It would be good to resolve this asap
> >
> > cheers
> >
> >
> >
> > _______________________________________________
> > ckan-dev mailing list
> > ckan-dev at lists.okfn.org
> > http://lists.okfn.org/mailman/listinfo/ckan-dev
> > Unsubscribe: http://lists.okfn.org/mailman/options/ckan-dev
> >
>
>
> _______________________________________________
> ckan-dev mailing list
> ckan-dev at lists.okfn.org
> http://lists.okfn.org/mailman/listinfo/ckan-dev
> Unsubscribe: http://lists.okfn.org/mailman/options/ckan-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.okfn.org/pipermail/ckan-dev/attachments/20130225/d63b7a67/attachment-0001.html>