[ckan-dev] master and minified files

[Adrià Mercader]

On 25 February 2013 14:31, David Raznick <david.raznick at okfn.org> wrote:
> Hello,
>
> When we discussed this, the plan was not to have minified files (except for
> external libraries that could be difficult to minimize) in master and only
> minimize them in release branch.  This seemed like the only way to get a
> cleaner git history. This must also have meant core extensions too.
This is what we agreed, please don't take into account the release
notes on the wiki as they need updating. Sorry about any confusion.

Adrià




> I am not sure why this approach changed and I do not currently understand
> the downsides of doing it this way?
>
> Thanks
>
> David
>
>
> On Mon, Feb 25, 2013 at 1:36 PM, Toby Dacre <toby.okfn at gmail.com> wrote:
>>
>>
>>
>> On 25 February 2013 09:29, Sean Hammond <sean.hammond at okfn.org> wrote:
>>>
>>> The release process says that we update the minified files on release
>>> branches before a release, and these minified files then get merged back
>>> into master:
>>>
>>> https://github.com/okfn/ckan/wiki/Release-Process
>>>
>>> It says nothing about core extensions but I would guess the paster
>>> minify command in those instructions should be modified to include the
>>> core extensions too.
>>
>>
>> yeah this seems sensible that they follow the same logic as they are
>> pretty much part of core
>>
>>>
>>>
>>> On 25/02/13 09:46, Toby Dacre wrote:
>>> > Hi,
>>> >
>>> > This has been discussed before but I've forgotten if we agreed on
>>> > anything.
>>> >
>>> > The issue is about the minified .js and .css files in ckan.
>>> >
>>> > My understanding is that following a bug with semicolons (why are we
>>> > using .js files by people who think semicolons are optional?) we are
>>> > updating minified vendor files when we update these libs.  Any ckan
>>> > minification (via paster) will ignore dirs called vendor and any sub
>>> > dirs.
>>> >
>>> > `paster minify <path>` will minify a dir and it's sub dirs but ignore
>>> > 'vendor'
>>> >
>>> > issues
>>> >
>>> > do we include the minified files in non-release branches?
>>> > - personally I think we should but they should only get updated in
>>> > master - in much the same way as main.css
>>> > - some people have objected to this
>>> >
>>> > do we include the minified files in release branches?
>>> > - if we do this we have problems around .gitignore files (imho)
>>> >
>>> > we need to make sure the decision we make also takes core extensions
>>> > into account
>>> > - currently `paster front-end-build` only worries about
>>> > ckan/public/base
>>> > - it also generates .css and some .js files used in translations
>>> >
>>> > It would be good to resolve this asap
>>> >
>>> > cheers
>>> >
>>> >
>>> >
>>> > _______________________________________________
>>> > ckan-dev mailing list
>>> > ckan-dev at lists.okfn.org
>>> > http://lists.okfn.org/mailman/listinfo/ckan-dev
>>> > Unsubscribe: http://lists.okfn.org/mailman/options/ckan-dev
>>> >
>>>
>>>
>>> _______________________________________________
>>> ckan-dev mailing list
>>> ckan-dev at lists.okfn.org
>>> http://lists.okfn.org/mailman/listinfo/ckan-dev
>>> Unsubscribe: http://lists.okfn.org/mailman/options/ckan-dev
>>
>>
>>
>> _______________________________________________
>> ckan-dev mailing list
>> ckan-dev at lists.okfn.org
>> http://lists.okfn.org/mailman/listinfo/ckan-dev
>> Unsubscribe: http://lists.okfn.org/mailman/options/ckan-dev
>>
>
>
> _______________________________________________
> ckan-dev mailing list
> ckan-dev at lists.okfn.org
> http://lists.okfn.org/mailman/listinfo/ckan-dev
> Unsubscribe: http://lists.okfn.org/mailman/options/ckan-dev
>