[ckan-dev] BaseController unused code

Thu Jan 10 11:40:48 UTC 2013

> lib.base.BaseController defines the following private functions that appear
> not to be used or if they are they are being mis-used.
> 
> Is anyone aware of why I shouldn't just delete them
> 
> _get_user(self, reference):
> _get_pkg(self, reference):
> _get_group(self, reference):
> _get_tag(self, reference):
> _get_request_data(cls, try_url_params=False):
> _make_unicode(cls, entity):
> _get_timing_cache_path(self):
> _handle_update_of_authz(self, domain_object):
> _prepare_authz_info_for_render(self, user_object_roles):

No idea, if they are private functions and are not used anywhere (and
I'm guessing there are not any unit tests calling them either) then I
say delete them, as long as the tests still pass afterwards.

You could search the git history to see what they were ever used for and
when they stopped being used