[ckan-dev] Github Issues

[Toby Dacre]

On 22 January 2013 12:04, Sean Hammond <sean.hammond at okfn.org> wrote:

> > Well, I take back what I just said... at least part of it. #290 just
> > started to show the same behaviour as #269
>
> If you mention the pull request's number (with a # in front of it) in a
> commit message on the pull request's branch then that commit shows twice
> on the pull request's page.


> When you have a separate issue and pull request, then it'll be the
> issue's number in your commit messages not the pull request's, so it
> doesn't happen.
>
> Unless people accidentally start using the pull request's number in
> their commit messages, not the issue's, which I've noticed people have
> been. We have some branches where half of the commit messages have the
> issue's number in them and half have the pull requests. Dunno if this
> could be a problem for Adria.
>
>
Consistency is good but you aren't going to know the pull requests id till
it's been created so the issue number is the one that we should be using.
If you then link the branch to the issue then you get the duplicate commits
in the issue but this is definitely a github bug and not the end of the
world.

Sometime github seems a bit random in it's behaviour like were it decides
to put comments etc but better than nothing.


_______________________________________________
> ckan-dev mailing list
> ckan-dev at lists.okfn.org
> http://lists.okfn.org/mailman/listinfo/ckan-dev
> Unsubscribe: http://lists.okfn.org/mailman/options/ckan-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.okfn.org/pipermail/ckan-dev/attachments/20130123/672640fd/attachment-0001.html>