[ckan-dev] formalchemy still here?

Wed Jun 26 10:27:50 UTC 2013

On 26 June 2013 11:17, David Read <david.read at hackneyworkshop.com> wrote:
> Can anyone explain the continued existence[1] of formalchemy in master
> CKAN? It looks like Toby did some of the removing of it last October,
> but there are still a few references. It seems an unnecessary
> dependency - is there any logic to keeping it?

I believe it should all be killed off - feel free to create a pull request

>
> [1]
> ./ckan/lib/field_types.py:    import formalchemy
> ./ckan/lib/field_types.py:            raise formalchemy.ValidationError(e)
> ./ckan/config/routing.py:    ##to get back formalchemy uncomment these lines
> ./ckan/config/routing.py:    ##map.connect('/group/new',
> controller='group_formalchemy', action='new')
> ./ckan/config/routing.py:    ##map.connect('/group/edit/{id}',
> controller='group_formalchemy', action='edit')
> ./ckan/tests/lib/test_field_types.py:import formalchemy
> ./ckan/tests/lib/test_field_types.py:
> self.assertRaises(formalchemy.ValidationError,
> DateType.form_validator, date_str)
> ./setup.py:    'formalchemy>=1.4.2',
>
> [2] https://github.com/okfn/ckan/pull/146/files#L1L207
>
> Dave
>
> _______________________________________________
> ckan-dev mailing list
> ckan-dev at lists.okfn.org
> http://lists.okfn.org/mailman/listinfo/ckan-dev
> Unsubscribe: http://lists.okfn.org/mailman/options/ckan-dev


-- 
Toby Dacre

The Open Knowledge Foundation

Empowering through Open Knowledge
http://okfn.org/  |  @okfn