[kforge-user] KForge v0.17 released

[John Bywater]

Hi Gunnar,

Thanks for you email. Sorry for the delay....

Gunnar Läthén wrote:
> Hi,
> 
> I finally dedicated some time to upgrade from 0.14 to 0.17 and it went 
> pretty smooth.

Thanks for using KForge. It's nice to know it's working for you.

However, there's one detail I can't figure out:  In 0.14
> I modified the source somewhere to hardcode https URLs (instead of http) 
> for the service listings.  No matter how I try I can't recreate this in 
> 0.17, my first guess was url.py, but that didn't lead to any changes.  
> Any hints?

First thing to say is: KForge now tries not to care where it is being 
served. That's why the url.py doesn't work in the same way as before. 
But I must admit that we need to finish off this aspect, and there are 
unfortunately places where KForge assumes HTTP.

At line 116 of kforge/django/apps/kui/views/service.py we have:

protocol = "http"

You could change this to:

protocol = "https"

and see if that works for you?

You may also need to change line 91 of kforge/plugin/mailman.py.

But we need to finish this aspect. Can you help me decide the 
requirements? The protocol could be detected from the request. Or we 
could set it in config. I'm not exactly sure what to do for the best. 
Should it be one or the other, or possibly both?

I'm inclined towards pulling it from the request (by using the 
HttpRequest.is_secure() method, right?) but sometimes the urls are 
generated without any request (in the mailman plugin above).

So perhaps we should use the request where possible, then fall back to 
the system dictionary default, which can be overridden by setting the 
value in the config file? Or should it always pull from the config file, 
so it's consistent and explicit? I just discussed this with Rufus, and I 
still can't decide.

How would you like it to be? If you tell me what you'd like, I'll try to 
do it just like that. ;-)

> 
> Thanks again for the very nice system,

Thanks for using KForge!

> Kind regards,  Gunnar Läthén

Best wishes,
John