No subject

Sun Mar 31 09:34:23 UTC 2013

=A0- what coding standards you have, or other expectations of the code<br>
(test coverage? comments? namespace management?)<br>
=A0- what is the practical workflow for review? [add comments to github<br>
pull requests?]<br>
=A0- how do I signal when I do/don&#39;t have time to contribute? [maybe th=
works if it&#39;s just &quot;review a pull request when you have time&quot;=
Perhaps a (very short) &quot;how to be a reviewer&quot; document would be u=
seful.<br></blockquote><div><br></div><div style>The web site doesn&#39;t a=
ppear to have a link to Github, but the stuff to be reviewed seems to be he=
<div style><a href=3D"">h=
ttps://</a><br></div><div style><=
br></div><div style>I couldn&#39;t find any documentation of the process or=
 standards in the wiki or source tree.</div>
<div style><br></div><div style>Even simple things like standard terminolog=
y are helpful. =A0The first one I looked at to get a feel for how things wo=
rked had a comment of &quot;This is a no-brainer.&quot; which is apparently=
 a sign of approval because it got merged. I&#39;d suggest +1 or Google&#39=
;s LGTM or some other standard approval phrase that&#39;s unambiguous.</div=
<div style><br></div><div style>In addition to Dan&#39;s (very good) questi=
ons, I&#39;d add:</div><div style><br></div><div style>- What factors deter=
mine when a change is high enough risk to require depolyment to the staging=
<div><br></div><div style>Tom=A0</div><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(=
<div><div class=3D"h5"><br>
On 05/06/13 12:31, Tryggvi Bj=F6rgvinsson wrote:<br>
&gt; Hi all,<br>
&gt; OpenSpending is a platform that a lot of users (other sites) rely on s=
&gt; we care deeply about quality assurance. One of the things we do as par=
&gt; of QA is code review. A developer should never merge his/her changes<b=
&gt; into master unless somebody else has looked over the changes and given=
&gt; them a &quot;go&quot;.<br>
&gt; For bigger changes we can also deploy the changes to our staging serve=
&gt; so code reviewers can test them on a live site as well.<br>
&gt; Now, this makes the contribution process a bit longer. You contribute,=
&gt; then you wait, then somebody reviews when that developer has time and<=
&gt; your changes (hopefully) get committed. If you need to make some more<=
&gt; changes you have to go back in line after you commit them.<br>
&gt; Therefore we need many code reviewers to keep the process fast. We do<=
&gt; not make any requirements of technical knowledge about OpenSpending bu=
&gt; the code reviewer should be proficient in both Python and Javascript<b=
&gt; (and web development in general). The job of the code reviewer is just=
&gt; to ask a lot of questions if there&#39;s any doubt as to why things ar=
&gt; implemented in a certain way.<br>
&gt; So I want to make a proposal. Let&#39;s do &quot;collaborative QA&quot=
;, we do code<br>
&gt; review exchange. Who on this list are willing to become a code reviewe=
&gt; for OpenSpending? In return I will become a code reviewer for their<br=
&gt; projects.<br>
&gt; --<br>
&gt; Tryggvi Bj=F6rgvinsson<br>
&gt; Technical Lead, OpenSpending<br>
</div></div>&gt; The Open Knowledge Foundation &lt;<a href=3D"http://okfn.o=
rg" target=3D"_blank"></a>&gt;<br>
&gt; /Empowering through Open Knowledge/<br>
&gt; <a href=3D"" target=3D"_blank"></a> | =
@okfn &lt;<a href=3D"" target=3D"_blank">http://twit=</a>&gt; | OKF on Facebook<br>
&gt; &lt;<a href=3D"" target=3D"_blank">http=
s://</a>&gt; | Blog &lt;<a href=3D"http://blog.okfn.=
org/" target=3D"_blank"></a>&gt; |<br>
&gt; Newsletter &lt;<a href=3D"" target=3D"=
&gt; _______________________________________________<br>
&gt; okfn-labs mailing list<br>
&gt; <a href=3D"mailto:okfn-labs at">okfn-labs at</=
&gt; <a href=3D"" target=3D=
&gt; Unsubscribe: <a href=3D"
s" target=3D"_blank"></a><br=
Dan O&#39;Huiginn<br>
Organised Crime and Corruption Reporting Project<br>
<a href=3D"mailto:daniel at">daniel at</a><br>
<a href=3D"" target=3D"_blank"></a> @=
<a href=3D"" target=3D"_blank">http://reportingp=</a><br>
okfn-labs mailing list<br>
<a href=3D"mailto:okfn-labs at">okfn-labs at</a><br=
<a href=3D"" target=3D"_bla=
Unsubscribe: <a href=3D"" ta=


More information about the okfn-labs mailing list