[ckan-dev] killing cookies

Fri Mar 9 18:13:53 UTC 2012

On 9 March 2012 18:10, Toby Dacre <toby.okfn at gmail.com> wrote:
>
>
> On 9 March 2012 17:58, David Read <david.read at hackneyworkshop.com> wrote:
>>
>> On 9 March 2012 17:45, Toby Dacre <toby.okfn at gmail.com> wrote:
>> > David,
>> >
>> > Thanks for the info.  Yes I'm planning to delete the cookies if they
>> > exist
>> > for a version or two.
>> >
>> > I'd quite like to remove the ckan_killtopbar cookie too but that would
>> > need
>> > further discussion and is all client side and so can be ignored for
>> > caching
>> > even if it makes the config slightly more effort.
>>
>> I agree! Do you mean to use javascript to set the cookie? Surely the
>> browser will still send the cookie on future requests, which will tell
>> Varnish not to return from the cache?
>
>
> Yes, but varnish/nginx can be told to ignore this cookie and still use the
> cache but this means we have to do a custom config for them and also doesn't
> play nice with other proxies if we go through any.
>
>>
>>
>> BTW I think CKAN should be configurable to not have that the 'welcome
>> bar' at all, solving this problem for clients that use a cache and
>> have no need for the welcome bar.
>
>
> That's one option but I'd like to see it go. IMHO the help link on the page
> should be easy to find so that the bar is not needed.

I was going to start a campaign along these lines! Rufus justified it
since stackoverflow.com has it.

Does anyone else here with feelings for/against the 'welcome bar'?

Dave

>
> Toby
>>
>>
>> Dave
>>
>> >
>> > Toby
>> >
>> >
>> > On 9 March 2012 16:42, David Read <david.read at hackneyworkshop.com>
>> > wrote:
>> >>
>> >> Toby,
>> >>
>> >> These cookies derive from these commits:
>> >>
>> >>
>> >>
>> >> https://github.com/okfn/ckan/commit/026f78a66322aaae310f178c7fe1da531454d146
>> >>
>> >>
>> >> https://github.com/okfn/ckan/commit/ea92ab801fbf214b7567b8ef31f782517460854e
>> >>
>> >> which were put in during a previous effort to improve CKAN pages'
>> >> cacheability.
>> >>
>> >> These cookies are not used in the templates any more, so I'm pleased
>> >> to see you deleting their creation. May be worth leaving the
>> >> 'delete_cookie' commands in for a version of CKAN, though?
>> >>
>> >> David
>> >>
>> >> On 9 March 2012 11:18, Toby Dacre <toby.okfn at gmail.com> wrote:
>> >> > Hi,
>> >> >
>> >> > As part of the #2220 making ckan cacheable work I have removed the
>> >> > following
>> >> > client side cookies
>> >> >
>> >> > ckan_user
>> >> > ckan_display_name
>> >> > ckan_apikey
>> >> >
>> >> > From what I can see we do not use these anywhere in core is anyone
>> >> > aware
>> >> > of
>> >> > any use cases for them?
>> >> >
>> >> > Cheers
>> >> > Toby
>> >> >
>> >> > _______________________________________________
>> >> > ckan-dev mailing list
>> >> > ckan-dev at lists.okfn.org
>> >> > http://lists.okfn.org/mailman/listinfo/ckan-dev
>> >> >
>> >>
>> >> _______________________________________________
>> >> ckan-dev mailing list
>> >> ckan-dev at lists.okfn.org
>> >> http://lists.okfn.org/mailman/listinfo/ckan-dev
>> >
>> >
>> >
>> > _______________________________________________
>> > ckan-dev mailing list
>> > ckan-dev at lists.okfn.org
>> > http://lists.okfn.org/mailman/listinfo/ckan-dev
>> >
>>
>> _______________________________________________
>> ckan-dev mailing list
>> ckan-dev at lists.okfn.org
>> http://lists.okfn.org/mailman/listinfo/ckan-dev
>
>
>
> _______________________________________________
> ckan-dev mailing list
> ckan-dev at lists.okfn.org
> http://lists.okfn.org/mailman/listinfo/ckan-dev
>