[kforge-dev] PATCH: improve umask handling

[John Bywater]

Hi Martin,

Thank you very much. That's a great move.

I'll review with Rufus and get back to you asap.

Best wishes,

John.



Martin Fuzzey wrote:
> Hi,
> although the INSTALL file describes two ways of handling the file
> permissions (make everything owned by the webserver user or change the
> webserver scripts to set the umask) they both have problems:
> The first solution may cause incorrect permissions when running admin
> commands from the command line
> The second solution involves system level changes affecting all web
> applications run by apache (I've asked about this on the Debian lists
> and doing this is not allowed policy wise...)
>
> The attached patch implements a IMHO better solution involving :
> changing the umask for the kforge-admin command
> changing the umask for the duration of each web request
>
> This enables both command line and web access with no system umask
> changes providing the directory permissions are correctly set.
>
> Regards,
>
> Martin
>   
>