[wdmmg-dev] Failing tests in wdmmg

Rufus Pollock rufus.pollock at okfn.org
Wed Mar 16 21:59:55 UTC 2011


On 16 March 2011 19:50, Stefan Wehrmeyer <stefanwehrmeyer at gmail.com> wrote:
> Hi everybody,
>
> On 16.03.2011, at 20:38 , Carsten Senger wrote:
>> In the last days I cleaned up the tests in wdmmg and wdmmg-ext. For wdmmg
>> the testsuite passes without errors or failures apart from the following
>> two tests described below (and tests for the csv import Stefan is working
>> on currently). wdmmg-ext still has failures for 2 loaders, but at least
>> the spain loader is simply broken.
>
> First of all: thanks a lot for your work on that, much appreciated!
> I just committed fixes for csvimport and its tests.
>
>> In the next days I will document the test setup. If you have more tests
>> with errors or failures feel free to grep me. I'll also add wdmmg and
>> wdmmg-ext to the okfn buildbots.
>
> Awesome. And we really should think about deployment scripts (maybe using fabric),
> since our stack includes some background processes (celery, solr) that need to be setup correctly.
>
>> The 2 failing tests are tests for old rest urls. No routing is set up for
>> the urls.
>>
>> The tests were created in
>> <https://bitbucket.org/okfn/wdmmg/changeset/d83d3a5b1e16>,
>> the routes removed later in
>> <https://bitbucket.org/okfn/wdmmg/changeset/dc4240231a5e>
>>
>> Are these urls still needed or can I remove the tests?
>
> These are the URLs for the old API. I think somebody wanted to maintain backwards compatibility by keeping these URLs working and cool URIs don't change and all.
> But since we have moved to another domain, it doesn't matter and I'm in favor of removing the /api routes and their tests.

Open Spending is also running http://data.wheredoesmymoneygo.org/ and
we have plenty of clients still using old rest api urls i believe
(including the wdmmg explorer and the flash).

We should check here with Friedrich before removing anything as he
knows both the old and the new system.

Rufus




More information about the openspending-dev mailing list