[openspending-dev] Code review request

Tue May 14 12:41:13 UTC 2013

On þri 14.maí 2013 11:57, Tryggvi Björgvinsson wrote:
> I've been working on some of the issues marked 'Spending stories' in our
> issue tracker on github (plus some bugs) and pushed them to both
> openspending (4), openspendingjs (2), and satellite-template (1). So now
> we have open a total of 7 pull requests.

Hi again,

I know it's not been long but I just added two more pull requests (one
in openspendingjs and one in openspending). These were low hanging
fruits but I felt they needed to be fixed.

Code review is greatly appreciated for these (should be reaally easy).

The new pull requests are:

* Allow users to redefine drilldown behavoiur in treemaps (this enables
unique url generation/links and breadcrumbs just like in
openbudgetoakland) - openspendingjs
* Make templating directory neutral (not a hardcoded value) - openspending

-- 

Tryggvi Björgvinsson

Technical Lead, OpenSpending

The Open Knowledge Foundation <http://okfn.org>

/Empowering through Open Knowledge/

http://okfn.org/ | @okfn <http://twitter.com/OKFN> | OKF on Facebook
<https://facebook.com/OKFNetwork> | Blog <http://blog.okfn.org/> |
Newsletter <http://okfn.org/about/newsletter>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.okfn.org/pipermail/openspending-dev/attachments/20130514/00063fcb/attachment.html>